standardize the naming of karmada config in karmadactl method #5797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmada-bot
added
kind/feature
karmada-bot
added
the
size/L
|
test report: $ kubectl get pods -o wide -A
NAMESPACE NAME READY STATUS RESTARTS AGE IP NODE NOMINATED NODE READINESS GATES
karmada-system etcd-0 1/1 Running 0 34m 10.4.0.5 karmada-karmadactl-host-control-plane <none> <none>
karmada-system karmada-aggregated-apiserver-669cb58ff4-tcjmg 1/1 Running 0 33m 10.4.0.7 karmada-karmadactl-host-control-plane <none> <none>
karmada-system karmada-apiserver-799cfbb68f-mm8rd 1/1 Running 0 34m 10.4.0.6 karmada-karmadactl-host-control-plane <none> <none>
karmada-system karmada-controller-manager-7c54ff558b-f5zvn 1/1 Running 0 32m 10.4.0.10 karmada-karmadactl-host-control-plane <none> <none>
karmada-system karmada-descheduler-676b87df5d-swbvp 1/1 Running 0 9m17s 10.4.0.13 karmada-karmadactl-host-control-plane <none> <none>
karmada-system karmada-metrics-adapter-6b88554dc8-szqhq 1/1 Running 0 9m15s 10.4.0.14 karmada-karmadactl-host-control-plane <none> <none>
karmada-system karmada-scheduler-59764b9985-vgtmg 1/1 Running 0 32m 10.4.0.9 karmada-karmadactl-host-control-plane <none> <none>
karmada-system karmada-scheduler-estimator-member4-6c66449d5d-2tqwv 1/1 Running 0 79s 10.4.0.15 karmada-karmadactl-host-control-plane <none> <none>
karmada-system karmada-search-56767867fc-jhxch 1/1 Running 0 9m20s 10.4.0.12 karmada-karmadactl-host-control-plane <none> <none>
karmada-system karmada-webhook-b468fdcf4-m2zwv 1/1 Running 0 31m 10.4.0.11 karmada-karmadactl-host-control-plane <none> <none>
karmada-system kube-controller-manager-857745f88b-ptqgj 1/1 Running 0 32m 10.4.0.8 karmada-karmadactl-host-control-plane <none> <none>
kube-system coredns-6f6b679f8f-p4kxn 1/1 Running 0 38m 10.4.0.2 karmada-karmadactl-host-control-plane <none> <none>
kube-system coredns-6f6b679f8f-rwbl6 1/1 Running 0 38m 10.4.0.3 karmada-karmadactl-host-control-plane <none> <none>
kube-system etcd-karmada-karmadactl-host-control-plane 1/1 Running 0 38m 172.18.0.7 karmada-karmadactl-host-control-plane <none> <none>
kube-system kindnet-rwfkq 1/1 Running 0 38m 172.18.0.7 karmada-karmadactl-host-control-plane <none> <none>
kube-system kube-apiserver-karmada-karmadactl-host-control-plane 1/1 Running 0 38m 172.18.0.7 karmada-karmadactl-host-control-plane <none> <none>
kube-system kube-controller-manager-karmada-karmadactl-host-control-plane 1/1 Running 0 38m 172.18.0.7 karmada-karmadactl-host-control-plane <none> <none>
kube-system kube-proxy-vgwx6 1/1 Running 0 38m 172.18.0.7 karmada-karmadactl-host-control-plane <none> <none>
kube-system kube-scheduler-karmada-karmadactl-host-control-plane 1/1 Running 0 38m 172.18.0.7 karmada-karmadactl-host-control-plane <none> <none>
local-path-storage local-path-provisioner-57c5987fd4-v27d5 1/1 Running 0 38m 10.4.0.4 karmada-karmadactl-host-control-plane <none> <none> |
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5797 +/- ##
==========================================
- Coverage 48.36% 48.35% -0.02%
==========================================
Files 666 667 +1
Lines 54842 54848 +6
==========================================
- Hits 26527 26520 -7
- Misses 26595 26607 +12
- Partials 1720 1721 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
chaosi-zju
force-pushed
the
secret-karmadactl-2
branch
from
9f6ced1 to
e8998f6
Compare
2 tasks
chaosi-zju
force-pushed
the
secret-karmadactl-2
branch
3 times, most recently
from
daad16b to
8e78b20
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: chaosi-zju <[email protected]>
chaosi-zju
force-pushed
the
secret-karmadactl-2
branch
from
8e78b20 to
a8c95c7
Compare
|
PR is ready, @RainbowMango latest test report: $ kubectl get secret -n karmada-system
NAME TYPE DATA AGE
etcd-cert Opaque 4 2m40s
karmada-aggregated-apiserver-config Opaque 1 2m40s
karmada-cert Opaque 16 2m40s
karmada-controller-manager-config Opaque 1 2m40s
karmada-descheduler-config Opaque 1 2m40s
karmada-metrics-adapter-config Opaque 1 2m40s
karmada-scheduler-config Opaque 1 2m40s
karmada-search-config Opaque 1 2m40s
karmada-webhook-cert Opaque 2 2m40s
karmada-webhook-config Opaque 1 2m40s
kube-controller-manager-config Opaque 1 2m40s
member4-kubeconfig Opaque 1 42s
$ kubectl get pods -n karmada-system
NAME READY STATUS RESTARTS AGE
etcd-0 1/1 Running 0 2m11s
karmada-aggregated-apiserver-cd487bf7b-fgz44 1/1 Running 0 95s
karmada-apiserver-5c58546979-9fvsg 1/1 Running 0 2m8s
karmada-controller-manager-d6b65f748-wcj9q 1/1 Running 0 88s
karmada-descheduler-65d9d48fdb-sj4pn 1/1 Running 0 18s
karmada-metrics-adapter-665444967b-qndkw 1/1 Running 0 27s
karmada-scheduler-765dcfbddf-crnxj 1/1 Running 0 89s
karmada-scheduler-estimator-member4-86c6568998-gllzz 1/1 Running 0 14s
karmada-search-fd9f84555-zk6cx 1/1 Running 0 21s
karmada-webhook-75fd7b67db-x8q6k 1/1 Running 0 87s
kube-controller-manager-58646bb75d-6kskd 1/1 Running 0 90s |
|
OK. will do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind cleanup
What this PR does / why we need it:
In karmada, here are two important secrets, which is mount by most karmada components. One is karmada-cert, which contains a series of cert files like ca.crt, apiserver.crt and so on; another is karmada-kubeconfig, which contains a kubeconfig of karmada-apiserver.
However, in different installation methods, we used inconsistent secret naming or file path naming, which can potentially cause some unnecessary problems, detail refer to #5363.
This PR aims to standardize the naming of karmada config in
karmadactlinstallation method.Which issue(s) this PR fixes:
Fixes part of #6051
Special notes for your reviewer:
karmada-agent is a bit different, this PR doesn't include the rename of karmada-agent
Does this PR introduce a user-facing change?: