Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Updates in files #6027

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

yashpandey06
Copy link
Contributor

What type of PR is this?

/kind deprecation
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #6024

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. kind/feature Categorizes issue or PR as related to a new feature. labels Jan 8, 2025
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 8, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.36%. Comparing base (56194cb) to head (6cba9fe).
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6027      +/-   ##
==========================================
+ Coverage   48.35%   48.36%   +0.01%     
==========================================
  Files         665      665              
  Lines       54831    54831              
==========================================
+ Hits        26512    26521       +9     
+ Misses      26599    26592       -7     
+ Partials     1720     1718       -2     
Flag Coverage Δ
unittests 48.36% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yashpandey06
Copy link
Contributor Author

Tests failing due to version updates ?

@RainbowMango
Copy link
Member

/assign @zhzhuang-zju

@liangyuanpeng
Copy link
Contributor

#3 [internal] load metadata for docker.io/library/alpine:3.21.0
#3 ERROR: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/alpine/blobs/sha256:4048db5d36726e313ab8f7ffccf2362a34cba69e4cdd49119713483a68641fce: 403 Forbidden
------
 > [internal] load metadata for docker.io/library/alpine:3.21.0:
------
Dockerfile:15
--------------------
  13 |     # limitations under the License.
  14 |     
  15 | >>> FROM alpine:3.21.0
  16 |     
  17 |     ARG BINARY
--------------------
ERROR: failed to solve: alpine:3.21.0: failed to resolve source metadata for docker.io/library/alpine:3.21.0: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/alpine/blobs/sha2[56](https://github.com/karmada-io/karmada/actions/runs/12673922800/job/35321382891?pr=6027#step:12:57):4048db5d36726e313ab8f7ffccf2362a34cba69e4cdd49119713483a68641fce: 403 Forbidden
make: *** [Makefile:[58](https://github.com/karmada-io/karmada/actions/runs/12673922800/job/35321382891?pr=6027#step:12:59): image-karmada-aggregated-apiserver] Error 1
make: Leaving directory '/home/runner/work/karmada/karmada'

/kind cleanup
/ok-to-test
/retest

@karmada-bot karmada-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. ok-to-test labels Jan 9, 2025
@yashpandey06
Copy link
Contributor Author

Re-Run has passed the tests .

.gitignore Outdated
@@ -25,3 +25,5 @@ _output/
# sub chart tgz
charts/karmada/charts
charts/karmada-operator/charts

.codegpt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is it? by the way.

And please add a new line at the end of the file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RainbowMango I have fixed it in the latest commits .

@yashpandey06 yashpandey06 force-pushed the version-updates branch 2 times, most recently from 04ff648 to f44beca Compare January 9, 2025 09:26
Signed-off-by: YASH PANDEY <[email protected]>
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/remove-kind deprecation
/lgtm
Thanks @yashpandey06
leave approval to @zhzhuang-zju

@karmada-bot karmada-bot added lgtm Indicates that a PR is ready to be merged. and removed kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. labels Jan 9, 2025
@zhzhuang-zju
Copy link
Contributor

Thanks
/lgtm

@zhzhuang-zju
Copy link
Contributor

/approve

@zhzhuang-zju
Copy link
Contributor

It looks like I don't have enough authority to approve this pr, so lever the final approval to @RainbowMango

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango, zhzhuang-zju

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2025
@karmada-bot karmada-bot merged commit be674c7 into karmada-io:master Jan 10, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update obsolete information
6 participants