-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config security context #6052
config security context #6052
Conversation
7b8362c
to
293a6af
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #6052 +/- ##
=======================================
Coverage 48.36% 48.36%
=======================================
Files 666 666
Lines 54831 54842 +11
=======================================
+ Hits 26519 26526 +7
- Misses 26593 26596 +3
- Partials 1719 1720 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: zhzhuang-zju <[email protected]>
293a6af
to
3e9ef29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
A security context defines privilege and access control settings for a Pod or Container. More details can refer to https://www.dynatrace.com/engineering/blog/kubernetes-security-part-3-security-context/
This PR restricted the component's security context, including,
allowPrivilegeEscalation
to falseprivileged
to false,seccompProfile
toRuntimeDefault
Regarding
runAsUser
andrunAsNonRoot
, unfortunately, imposing these restrictions resulted in abnormal functionality of the component, so they could not be applied. As forreadOnlyRootFilesystem
, implementing this would reduce convenience during troubleshooting. Given that the manifests files maintained under theartifacts
directory are primarily used by developers, this PR decides not to set this option for now.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
For other installation methods, this configuration can be adapted later, and it should provide users with the ability to customize security context.
Does this PR introduce a user-facing change?: