add translations #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
configure the helper to first try to lookup translations in state.[alpha2].[subdivision key] and default to English
For translating of subdivisions on country change, send the locale in the request.
|
commit 9d8d85a fixes issue with ajax request by sending the locale along so that the translations work in ajax too. |
do not use I18n for subdivision names so the source of truth is the Subdivision name in our app that we registered with ISO3166::Data.register, not the translation file - subdivisions do not need translations anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configure the helper to first try to lookup translations in state.[alpha2].[subdivision key] and default to English