Skip to content
This repository has been archived by the owner on Apr 2, 2021. It is now read-only.

Feature/expiredkeys pt1 #86

Merged
merged 5 commits into from
Aug 28, 2018
Merged

Feature/expiredkeys pt1 #86

merged 5 commits into from
Aug 28, 2018

Conversation

kasvith
Copy link
Owner

@kasvith kasvith commented Aug 28, 2018

Pull Request for issue #81

Description

  • Created a new method for get key from db, which checks for expiration
  • Added RWMutex to DataNode
  • Added expire key ttl command
  • Updated keys command to check ttl

Testing Instructions

  • Add some keys to db
  • Use expire to set expiration
  • After that time try Getting all the keys

Excepted Behavior

  • Only unexpired keys returned

Actual Behavior

  • Only unexpired keys returned

Additional Comments

  • Note will not clean at when keys were fetched

@kasvith kasvith added enhancement New feature or request level:intermediate issues that requires intermediate knowledge server issues related to kache-server labels Aug 28, 2018
@kasvith kasvith added this to the First Release milestone Aug 28, 2018
@kasvith kasvith self-assigned this Aug 28, 2018
@kasvith
Copy link
Owner Author

kasvith commented Aug 28, 2018

@chyroc can you review?

@codecov
Copy link

codecov bot commented Aug 28, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@7cbc516). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #86   +/-   ##
=========================================
  Coverage          ?   78.68%           
=========================================
  Files             ?       10           
  Lines             ?      774           
  Branches          ?        0           
=========================================
  Hits              ?      609           
  Misses            ?      155           
  Partials          ?       10
Impacted Files Coverage Δ
internal/arch/command-table.go 72.72% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cbc516...31f1265. Read the comment docs.

@kasvith kasvith merged commit 618ba80 into master Aug 28, 2018
@kasvith kasvith deleted the feature/expiredkeys-pt1 branch September 6, 2018 13:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request level:intermediate issues that requires intermediate knowledge server issues related to kache-server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants