Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use the wbw-database.json data in the Province and Contact page according to the new logic #799

Merged
merged 5 commits into from
Oct 1, 2021

Conversation

zainfathoni
Copy link
Member

Closes #787

Description

Current Tasks

  • (task 1)
  • (task 2)
  • (task 3)

@netlify
Copy link

netlify bot commented Sep 30, 2021

✔️ Deploy Preview for wargabantuwarga ready!

🔨 Explore the source changes: 59771f1

🔍 Inspect the deploy log: https://app.netlify.com/sites/wargabantuwarga/deploys/6155daaf6afef60007cb2e59

😎 Browse the preview: https://deploy-preview-799--wargabantuwarga.netlify.app

@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #799 (59771f1) into main (13bff56) will increase coverage by 0.10%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #799      +/-   ##
==========================================
+ Coverage   86.96%   87.06%   +0.10%     
==========================================
  Files         133      133              
  Lines        1427     1423       -4     
  Branches      458      454       -4     
==========================================
- Hits         1241     1239       -2     
+ Misses        182      180       -2     
  Partials        4        4              
Impacted Files Coverage Δ
components/contact-list-item.tsx 78.94% <0.00%> (+3.94%) ⬆️
pages/provinces/[provinceSlug]/index.tsx 100.00% <ø> (ø)
components/contact-details.tsx 100.00% <100.00%> (ø)
etc/fetchers/utils.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13bff56...59771f1. Read the comment docs.

@zainfathoni zainfathoni added the need-perf-check Trigger Lighthouse-CI check label Sep 30, 2021
@zainfathoni zainfathoni marked this pull request as ready for review September 30, 2021 16:03
@zainfathoni zainfathoni merged commit 14f396a into main Oct 1, 2021
@zainfathoni zainfathoni deleted the feature/wbw-database branch October 1, 2021 01:07
@zainfathoni zainfathoni added the hacktoberfest-accepted Accepted for Hacktoberfest participation label Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted for Hacktoberfest participation need-perf-check Trigger Lighthouse-CI check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the wbw-database.json data in the Province and Contact page according to the new logic
1 participant