Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move technical sections from domain specific #370

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

palagdan
Copy link
Collaborator

@palagdan palagdan commented Oct 14, 2024

Resolves #369

Copy link

netlify bot commented Oct 14, 2024

Deploy Preview for s-forms-kbss ready!

Name Link
🔨 Latest commit cd1d091
🔍 Latest deploy log https://app.netlify.com/sites/s-forms-kbss/deploys/670d19df9c29ea0008e796a4
😎 Deploy Preview https://deploy-preview-370--s-forms-kbss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@palagdan
Copy link
Collaborator Author

palagdan commented Oct 14, 2024

Blocked by #363.

This PR should be rebased after merging #363.

@blcham
Copy link
Collaborator

blcham commented Oct 16, 2024

I do not understand why there are so many changes. I cannot really check them. Did you do reformating as well? If you need 2 types of changes separate them in commits:

    1. Reformat
    1. Move technical sections

If you did not do formating and prettifier changed it automatically, you can most-likely revert state from Intellij Idea File History (not git history)

@palagdan
Copy link
Collaborator Author

palagdan commented Oct 18, 2024

@blcham
I used the S-Forms editor and only moved the date and technical sections to the separate input types section, and annotated a few questions. That's all. I'm not sure why it's showing so many changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move technical sections from domain specific questions to separate section in form1
2 participants