Update unit tests to not rely on queue priority

kean · May 5, 2024 · dbb37e4 · dbb37e4
1 parent cfcf386
commit dbb37e4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/Sources/Nuke/ImageTask.swift b/Sources/Nuke/ImageTask.swift
@@ -156,6 +156,9 @@ public final class ImageTask: Hashable, CustomStringConvertible, @unchecked Send
         lock = .allocate(capacity: 1)
         lock.initialize(to: os_unfair_lock())
 
+        // Important to call it before `imageTaskStartCalled`
+        pipeline.delegate.imageTaskCreated(self, pipeline: pipeline)
+
         task = Task {
             try await withUnsafeThrowingContinuation { continuation in
                 self.withState { $0.continuation = continuation }

diff --git a/Sources/Nuke/Pipeline/ImagePipeline.swift b/Sources/Nuke/Pipeline/ImagePipeline.swift
@@ -284,9 +284,7 @@ public final class ImagePipeline: @unchecked Sendable {
     // MARK: - ImageTask (Internal)
 
     private func makeStartedImageTask(with request: ImageRequest, isDataTask: Bool = false, onEvent: ((ImageTask.Event, ImageTask) -> Void)? = nil) -> ImageTask {
-        let task = ImageTask(taskId: nextTaskId, request: request, isDataTask: isDataTask, pipeline: self, onEvent: onEvent)
-        delegate.imageTaskCreated(task, pipeline: self)
-        return task
+        ImageTask(taskId: nextTaskId, request: request, isDataTask: isDataTask, pipeline: self, onEvent: onEvent)
     }
 
     private func cancel(_ task: ImageTask) {