-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added AdvancedEnchantments #73
base: master
Are you sure you want to change the base?
Conversation
Also mention that his website shows prices higher than even possible on spigot (to make discounts look even bigger) also you cant review plugins on his site, or dislike other reviews (you can only like them, dislike button is not functioning) |
change it from AE to GC. in general |
oh - and about the roman numeral code? yeah here's the stack overflow answer where he pasted the entire thing from - main method, class name, and all https://stackoverflow.com/a/9073310/11427550 |
Wierd that a competitor would make this PR 🤔 |
Competitor that doesn't have a 3000-line long switch statement |
So what? All the class does is convert numbers... it doesn't contribute to the core functionality of the plugin. It would be a different story if he was reselling other plugin's code, which afaik is not the case. I don't see an issue here. To me, this looks like you are using this public list to get more sales by getting people to believe your plugin is better. It's not right. |
except his plugin is libre software |
https://paste.willfp.com/hepeminaro.java the main class that controls all the effects is a gigantic switch statement |
Added AdvancedEnchantments - the list of problems is so big that it would be longer than the entire rest of the readme