Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indicate islands' inaccessibility #729

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

Nescio0
Copy link
Contributor

@Nescio0 Nescio0 commented May 12, 2021

Switzerland is impassable and therefore solid black on the map, which is clear and unambiguous. However, Iceland, Ireland, Corsica, Sardinia, Sicily, Crete, Cyprus, and other islands are inaccessible too, yet they aren't indicated as such. Crete and Sardinia are always in the neutral colour, whereas the rest are considered part of the nearest coastal area and change colour accordingly. The current situation is:

  • inconsistent: why treat Switzerland, Sardinia, and Crete differently?
  • incorrect: Corsica has been French since 1768, not Italian; Iceland was Danish, never British; and Cyprus was a British protectorate since 1878.
  • distracting: people look at the map to see what has changed; Iceland changing colour whenever a fleet enters Clyde does not help.

This pull requests proposes treating Switzerland and all islands exactly the same, by using a very dark grey (rgb = (32, 32, 32) or #202020), to indicate units can't move there, and no longer have them change colour, regardless what happens in nearby coastal areas.

This is how it would look at game start:
start_new

For comparison:
webdiplomacy.net:
webdiplomacy
playdiplomacy.com:
playdiplomacy
backstabbr.com:
backstabbr

@Nescio0
Copy link
Contributor Author

Nescio0 commented May 12, 2021

The BuildAnywhere, CustomStart, and FleetRome variants don't have map.png and smallmap.png files, however, ClassicChaos, ClassicFvA, and ClassicGvI do.
Are those actually any different from the maps of the Classic variant?

[EDIT] Yes, they are: on the smallmapNames.png of the Classic variant, some names are vertical, whereas on the ClassicChaos, ClassicFvA, and ClassicGvI variants, all names are horizontal. Furthermore, the border of the Heligoland Bight is larger too. There might be some other tiny differences.

@PeregrineFlight
Copy link
Contributor

PeregrineFlight commented May 6, 2022

Personally, I think the dark grey is too dark. It stands out too much from the rest of the primarily light-coloured map. I've actually done some asking-around in the past on this topic, and most people agree that colouring all impassable spaces black looks bad.

I once did a selection of potential options, which can be found here. People on the Discord server seemed to like # 4 best, with impassable islands coloured in light grey, but Switzerland left black. (below)

Regardless, any change of this magnitude would require some sort of broader public discussion.

4  Impassable Grey Black Switz - smallmap
4  Impassable Grey Black Switz - map

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants