fix: skip deprecated keyboards #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The search now skips deprecated and non-Unicode keyboards by default. Passing the parameter obsolete=1 will list all keyboards including obsolete ones. Obsolete keyboards will always be listed last.
jahorton
reviewed
Aug 5, 2020
| $json = json_decode(json_encode($json)); | ||
| $this->schema->in($json); | ||
| $this->assertJsonStringEqualsJsonFile(__DIR__ . '/fixtures/Search.2.0.khmer.json', json_encode($json), "Search for 'khmer' gives same results as Search.2.0.khmer.json"); | ||
| } | ||
|
|
||
| public function testPhraseSearchResult() | ||
| { | ||
| $json = $this->s->GetSearchMatches(null, 'khmer angkor', 1); | ||
| $json = $this->s->GetSearchMatches(null, 'khmer angkor', 1, 1); |
There was a problem hiding this comment.
Do we have any tests where the new obsolete parameter is 0?
jahorton
approved these changes
Aug 5, 2020
Base automatically changed from
fix/use-keyboards-bcp47-tag-in-links
to
staging
August 6, 2020 02:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The search now skips deprecated and non-Unicode keyboards by default. Passing the parameter obsolete=1 will list all keyboards including obsolete ones. Obsolete keyboards will always be listed last.
Front end on keyman.com keymanapp/keyman.com#147
Relates to #87.