feat(android): Android install page #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
darcywong00
reviewed
Oct 5, 2020
darcywong00
requested changes
Oct 6, 2020
keyboards/install.php
Outdated
| 'name' => $keyboard->name, | ||
| 'host' => KeymanHosts::Instance()->downloads_keyman_com, | ||
| 'tier' => $tier, | ||
| 'version' => $version, |
There was a problem hiding this comment.
Suggested change
| 'version' => $version, | |
| 'version' => $keyboard->version, |
Since $version is the Keyman for Android version for the tier, I was getting a non-existent keyboard link
https://downloads.keyman.com/keyboards/sil_ipa/13.0.6218/sil_ipa.kmp
Do we still need $version = self::$versions->android->$tier if the "Install Keyman for Android" link goes straight to the Play Store?
There was a problem hiding this comment.
Also fixed on iOS PR #184 and for Linux and macOS pages.
Base automatically changed from
feat/ios-install-page
to
chore/collect-php_error.log-in-ci
October 7, 2020 00:00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to keymanapp/api.keyman.com#109.