Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add info to .htaccess #424

Merged
merged 3 commits into from
Feb 14, 2024
Merged

chore: Add info to .htaccess #424

merged 3 commits into from
Feb 14, 2024

Conversation

darcywong00
Copy link
Contributor

No description provided.

@darcywong00 darcywong00 added this to the B17S1 milestone Feb 13, 2024
@mcdurdin
Copy link
Member

This isn't needed, https://keyman.com/_control/info already works due to the global .php extension stripping. In fact, we don't need the rule for ready.php either!

Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest removing the control rules, then LGTM for the additions to info.php

.htaccess Outdated Show resolved Hide resolved
Co-authored-by: Marc Durdin <[email protected]>
@mcdurdin mcdurdin merged commit 4aa779d into master Feb 14, 2024
2 checks passed
@mcdurdin mcdurdin deleted the chore/htaccess-info branch February 14, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants