change(web): add context tracker bksp handling, alignment-offset calculations 🖲️ #12911
+119
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
Base automatically changed from
change/web/keep-suggestion-transforms
to
master
January 16, 2025 08:49
mcdurdin
approved these changes
Jan 16, 2025
web/src/engine/predictive-text/worker-thread/src/main/correction/context-tracker.ts
Show resolved
Hide resolved
| @@ -127,15 +136,7 @@ export class TrackedContextState { | |||
| // Be sure to deep-copy the tokens! Pointer-aliasing is bad here. | |||
There was a problem hiding this comment.
"pointers" are not a thing in JS. But objects are.
There was a problem hiding this comment.
The only difference between pointers and object references is the ability to directly apply arithmetic to the pointer. The 'aliasing' aspect is what's key here, though.
web/src/engine/predictive-text/worker-thread/src/main/correction/context-tracker.ts
Outdated
Show resolved
Hide resolved
jahorton
changed the title
mcdurdin
reviewed
Jan 21, 2025
web/src/engine/predictive-text/worker-thread/src/main/correction/context-tracker.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been spun off from #12884.
This PR accomplishes two main goals to facilitate #12884:
I've performed rebasing and curation to make each individual commit (of the initial 3) as clean and self-contained as possible. Hopefully that helps with the review process.
@keymanapp-test-bot skip