Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add platforms to welcome titles #12990

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Meng-Heng
Copy link
Collaborator

fixes: #12896.

This PR is ready for reviews.

@keymanapp-test-bot skip

@mcdurdin mcdurdin changed the title chore: adds platforms to welcome titles chore: add platforms to welcome titles Jan 23, 2025
@mcdurdin
Copy link
Member

@Meng-Heng, I updated your PR to say "chore: add platforms to welcome titles" instead of "chore: adds platforms to welcome titles".

When writing PR titles (and commit messages), please refer to https://github.com/keymanapp/keyman/wiki/Pull-Request-and-Commit-workflow-notes#commit for guidelines, particularly:

  • Use the present tense ("add feature" not "added feature")
  • Use the imperative mood ("move cursor to..." not "moves cursor to...", nor "cursor movement", nor "cursor now moves")

(I know that these things are really tricky to get right in English!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

bug: URLs with duplicate h1s
4 participants