fix(mac): properly manage Input Method lifecycle #13006
Draft
+87
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moves handling of all KMInputMethodLifeCycle notifications to KMInputMethodAppDelegate and out of KMInputController because KMInputController instances are being cached by the OS and swapped in when the input method changes state Fixes: #12997
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves handling of all KMInputMethodLifeCycle notifications to KMInputMethodAppDelegate from KMInputController.
KMInputController instances are cached by the OS and swapped in when the input method changes state, making it challenging to keep a single active KMInputController as the observer of the KMInputMethodLifeCycle notifications.
Instead, when a KMInputController is activated by the OS, it simply updates KMInputMethodAppDelegate to point to itself and then instructs KMInputMethodLifeCycle to figure out what transition to make. When KMInputMethodLifeCycle determines the correct transition, it fires the notification messages. KMInputMethodAppDelegate receives these messages and orchestrates the correct changes to the event tap, the OSK window and KMInputController.
Fixes: #12997
@keymanapp-test-bot skip