-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(android): restores DOMRect polyfill for old Chrome support #13012
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts |
@@ -921,6 +921,9 @@ private static void copyAssets(Context context) { | |||
copyAsset(context, KMFilename_KmwCss, "", true); | |||
copyAsset(context, KMFilename_KmwGlobeHintCss, "", true); | |||
copyAsset(context, KMFilename_Osk_Ttf_Font, "", true); | |||
|
|||
// Needed until our minimum version of Chrome is 61.0+. | |||
copyAsset(context, KMFilename_JSPolyfill2, "", true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This corresponds to the KeymanWeb artifact
protected static final String KMFilename_JSPolyfill2 = "other-polyfills.js"; |
Does the KMEA/build.sh section copy this? (I'm not sure I see it)
Lines 76 to 90 in 486807f
# Copy KeymanWeb artifacts | |
echo "Copying Keyman Web artifacts" | |
cp "$KEYMAN_WEB_ROOT/build/app/webview/$CONFIG/keymanweb-webview.js" "$ENGINE_ASSETS/keymanweb-webview.js" | |
cp "$KEYMAN_WEB_ROOT/build/app/webview/$CONFIG/keymanweb-webview.js.map" "$ENGINE_ASSETS/keymanweb-webview.js.map" | |
cp "$KEYMAN_WEB_ROOT/build/app/webview/$CONFIG/map-polyfill.js" "$ENGINE_ASSETS/map-polyfill.js" | |
cp "$KEYMAN_WEB_ROOT/build/app/resources/osk/ajax-loader.gif" "$ENGINE_ASSETS/ajax-loader.gif" | |
cp "$KEYMAN_WEB_ROOT/build/app/resources/osk/kmwosk.css" "$ENGINE_ASSETS/kmwosk.css" | |
cp "$KEYMAN_WEB_ROOT/build/app/resources/osk/globe-hint.css" "$ENGINE_ASSETS/globe-hint.css" | |
cp "$KEYMAN_WEB_ROOT/build/app/resources/osk/keymanweb-osk.ttf" "$ENGINE_ASSETS/keymanweb-osk.ttf" | |
cp "$KEYMAN_ROOT/node_modules/@sentry/browser/build/bundle.min.js" "$ENGINE_ASSETS/sentry.min.js" | |
cp "$KEYMAN_ROOT/web/src/engine/sentry-manager/build/lib/index.js" "$ENGINE_ASSETS/keyman-sentry.js" | |
echo "Copying es6-shim polyfill" | |
cp "$KEYMAN_ROOT/node_modules/es6-shim/es6-shim.min.js" "$ENGINE_ASSETS/es6-shim.min.js" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't need to. It's checked in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, that's where it was
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
For 19.0, we should raise the minimum version to 95? (That's the last version that runs on Android 5.0) |
Fixes #11652.
From our current
master
:keyman/android/docs/help/about/system-requirements.md
Lines 11 to 15 in 486807f
DOMRect
has native support starting in Chrome 61.@keymanapp-test-bot skip