-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(web): fix handling of data: url fonts, fonts with single quotes in filename #13032
base: master
Are you sure you want to change the base?
Conversation
User Test ResultsTest specification and instructions
Results Template
Test Artifacts
|
I don't think this is true -- that's a separate Keyman Developer bug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
You think there's something else on that side of things, past the Web issues that'd probably also affect the behavior? |
Yes. Take a look at PR #13020 associated with #13017 which already fixed the issue 😁 Font filenames are rewritten by Keyman Developer Server (for reasons relating to how fonts are made available in the dev environment...), so the quote issue cannot arise there in the uri. |
1c934cb
to
ee7ca4c
Compare
Force-pushed to remove the link to an issue not actually fixed by this PR. |
Fixes: #13018
Fixes: #13022
Our fontface-defining stylesheet format has been using single-quotes to enclose the filename. Sadly,
encodeURI
doesn't mangle single-quotes - it mangles double-quotes instead. So, we should adjust the quote type used there.Fixed stylesheet:
When using the KMP loader to diagnose the problem, I found that data URLs were handled... to a point, and then that process was unnecessarily aborted. That was simple enough to fix with the first commit of this PR.
User Testing
This is how the default layer of the keyboard looks in desktop-mode Keyman Engine for Web:
TEST_ANDROID: Using the Android test build from this PR and the
soninke_n_ti.kmp
package from https://jahorton.github.io/soninke_n_ti.kmp, verify that the keyboard loads properly and has proper characters for its font.TEST_IOS: Using the Android test build from this PR and the
soninke_n_ti.kmp
package from https://jahorton.github.io/soninke_n_ti.kmp, verify that the keyboard loads properly and has proper characters for its font.