feat(windows): rework download keyboard dialog style #3463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 6, 2020
jahorton
approved these changes
Aug 7, 2020
mcdurdin
deleted the
feat/windows/rework-download-keyboard-dialog-style
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to keymanapp/api.keyman.com#87. Changes go together with keymanapp/keyman.com#153.
This cleans up the dialog style, reducing clutter, and makes navigation work better.
Majority of the changes relate to supporting the "Back" button which turns out to be non-trivial:
Screenshots for within Keyman for Windows. These should be similar for Keyman for macOS and Keyman for Linux. See keymanapp/keyman.com#153 for mockups for iOS/Android.
Initial screen
Search for "Khmer"
Clicked on "Khmer Angkor"