refactor(web): unifies touch-layout typing, updating Web to the common/web/types version 🐵 #9663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required |
jahorton
force-pushed
the
refactor/web/common-layout-typing
branch
from
6898439 to
41ae974
Compare
jahorton
force-pushed
the
feat/web/base-recognizer-integration
branch
from
0429a1c to
de83fee
Compare
|
Dang it... forgot to change the base after moving the noted base branch after this one via rebasing. Replacement is up at #9664. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to integrate the Web OSK for our new, upcoming gesture types... Web needs the corresponding type information. Rather than continue to keep the touch-layout typing WET, I've put in the work necessary to have Web use the definitions from
common/web/types- meaning KMW will now use the exact same type specification as Developer's Web-keyboard compiler.There were a few rough edges to resolve in doing so, but it also provided a wonderful excuse to take care of a few longstanding nits we've had. In particular, Web finally gets to say farewell to
stringformpad,width, andsptyping - though it keeps the legacy-friendlysanitizemethods that enforce the correct typing viaNumber.parse.The main benefit: Web now has access to flick and multitap layout-spec data, which I'll need for upcoming work.
This was motivated by follow-up work to #9657, but since that starts ripping apart KMW's OSK to the point that certain integration tests will be failing, it's probably clearer for the review process (and for management checks) to 'base' it just before that point.
@keymanapp-test-bot skip