Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(linux): Fix uninstallation of shared keyboard #9880

Merged
merged 1 commit into from
Oct 30, 2023
Merged

fix(linux): Fix uninstallation of shared keyboard #9880

merged 1 commit into from
Oct 30, 2023

Conversation

ermshiperete
Copy link
Contributor

This fixes the uninstallation of shared keyboards if the additional-keyboards settings doesn't exist yet.

Closes #9879.

User Testing

Preparations

Tests

TEST_WORKS:

  • Uninstall the shared keyboard: sudo km-package-uninstall -s hieroglyphic
  • verify that there are no errors or warnings shown in the terminal

@ermshiperete
fix(linux): Fix uninstallation of shared keyboard
3cc016f 
This fixes the uninstallation of shared keyboards if the
`additional-keyboards` settings doesn't exist yet.

Closes #9879.
@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels Oct 27, 2023
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Oct 27, 2023 •
edited
Loading

User Test Results

Test specification and instructions

  • ✅ TEST_WORKS (PASSED): Tested with the attached PR build (Keyman 17.0.200-alpha-local (package version 17.0.200-1~PR-9880-1645.1+mantic1) in Ubuntu 23.10 Mantic Minotaur OS (VM) and here is my observation: 1. After running the above mentioned 'Uninstall' command, the shared keyboard is removed from the Keyman Configuration dialog. Seems to be working as expected.

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot added this to the A17S24 milestone Oct 27, 2023
@mcdurdin mcdurdin modified the milestones: A17S24, A17S25 Oct 27, 2023
@bharanidharanj
Copy link

Test Results

  • TEST_WORKS (PASSED): Tested with the attached PR build (Keyman 17.0.200-alpha-local (package version 17.0.200-1~PR-9880-1645.1+mantic1) in Ubuntu 23.10 Mantic Minotaur OS (VM) and here is my observation: 1. After running the above mentioned 'Uninstall' command, the shared keyboard is removed from the Keyman Configuration dialog. Seems to be working as expected.

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Oct 30, 2023
@ermshiperete ermshiperete merged commit 1180849 into master Oct 30, 2023
3 checks passed
@ermshiperete ermshiperete deleted the fix/linux/9879_UninstallShared branch October 30, 2023 18:56
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.203-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdurdin mcdurdin mcdurdin approved these changes

@darcywong00 darcywong00 Awaiting requested review from darcywong00 darcywong00 is a code owner

Assignees
No one assigned
Labels
fix has-user-test linux/config/ linux/
Projects
None yet
Milestone
A17S25
Development

Successfully merging this pull request may close these issues.

bug(linux): Uninstallation of shared Hieroglyphic keyboard throws
4 participants
@ermshiperete @bharanidharanj @keyman-server @mcdurdin