Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(developer): use KeymanWeb.Codes for 17.0+ #9913

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

mcdurdin
Copy link
Member

@mcdurdin mcdurdin commented Oct 31, 2023

Fixes #8147.

Keyboards debug-compiled for web 17.0+ will use KeymanWeb.Codes. instead of keyman.osk..

User Testing

  • TEST_DEBUGGER: Create a new keyboard in Developer, and set its store(&VERSION) line to '17.0'. Compile the keyboard, and test it in the web debugger. Verify that the keyboard loads in Keyman Developer Server in the browser and that there are no Javascript errors (you will need to look at the Javascript console to be certain)

Fixes #8147.

Keyboards debug-compiled for web 17.0+ will use `KeymanWeb.Codes.`
instead of `keyman.osk.`.
@mcdurdin mcdurdin requested a review from darcywong00 as a code owner October 31, 2023 21:45
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Oct 31, 2023

User Test Results

Test specification and instructions

  • TEST_DEBUGGER (PASSED): )

Test Artifacts

@bharanidharanj
Copy link

Test Results

  • TEST_DEBUGGER (FAILED): Tested with Keyman Developer 17.0.204-alpha-test-9913 on Windows 11 OS (VM) and here is my observation: 1. Created a new keyboard using Keyman developer. 2. Set the Version number. 3.Compiled the Keyboard. Got a warning message 'You must include debug information to start the debugger. Check 'Include debug information' in the Keyboard menu'. 4. I noticed that the 'Include Debug Information' option was already checked. 5. I am getting this message repeated whenever I try to start debugging option. Seems to be an issue.

@keymanapp-test-bot keymanapp-test-bot bot added user-test-failed and removed user-test-required User tests have not been completed labels Nov 1, 2023
@mcdurdin mcdurdin changed the base branch from master to fix/developer/9885-debug-flag-not-working-in-tike November 2, 2023 03:46
@mcdurdin
Copy link
Member Author

mcdurdin commented Nov 2, 2023

@bharanidharanj thanks for this test. It looks like you bumped up against the fix in #9901. I have rebased this to include that fix, so if you could retest this, that'd be great, thanks!

@keymanapp-test-bot retest

@keymanapp-test-bot keymanapp-test-bot bot added user-test-required User tests have not been completed and removed user-test-failed labels Nov 2, 2023
Base automatically changed from fix/developer/9885-debug-flag-not-working-in-tike to master November 2, 2023 03:49
@bharanidharanj
Copy link

@bharanidharanj thanks for this test. It looks like you bumped up against the fix in #9901. I have rebased this to include that fix, so if you could retest this, that'd be great, thanks!

@keymanapp-test-bot retest

@mcdurdin Sure, I will do it.

@bharanidharanj
Copy link

Test Results

  • TEST_DEBUGGER (PASSED): Installed the updated Keyman Developer (17.0.204-alpha-test-9913) on Windows 11 OS (VM) and here is my observation: 1. Created a new keyboard in Developer and set its version by adding 'store(&VERSION) '17.0' line the code window. 2. Compiled the keyboard. 3. Verified that the keyboard was loaded in Keyman Developer Server in the browser and no javascript errors appeared in the console. Seems to be working as expected.

..Version number added

..Keyboard was loaded in the KD Server

..No Javascript error in the console

..Able to see the added keyboard on the browser

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Nov 2, 2023
@mcdurdin
Copy link
Member Author

mcdurdin commented Nov 2, 2023

@bharanidharanj, I'm sorry, I wasn't clear on the console. The console is the Web Developer Console, available by pressing F12 and selecting the Console tab:

image

Would you mind retesting please?

@keymanapp-test-bot retest

@keymanapp-test-bot keymanapp-test-bot bot added the user-test-required User tests have not been completed label Nov 2, 2023
@bharanidharanj
Copy link

@bharanidharanj, I'm sorry, I wasn't clear on the console. The console is the Web Developer Console, available by pressing F12 and selecting the Console tab:

image

Would you mind retesting please?

@keymanapp-test-bot retest

@mcdurdin Thanks for the clarification. Yes, I will retest and add my comment.

@bharanidharanj
Copy link

Test Results

  • TEST_DEBUGGER (FAILED): Retested as per your instructions and here is my observation: 1. Got an error message in the Web Developer Console. Seems to be an issue.

@keymanapp-test-bot keymanapp-test-bot bot added user-test-failed and removed user-test-required User tests have not been completed labels Nov 2, 2023
@mcdurdin
Copy link
Member Author

mcdurdin commented Nov 2, 2023 via email

@mcdurdin mcdurdin merged commit 1ffa3e2 into master Nov 3, 2023
2 checks passed
@mcdurdin mcdurdin deleted the fix/developer/8147-use-KeymanWeb.Codes branch November 3, 2023 01:21
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.205-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(developer): use new KeymanWeb.Codes prefix for 17.0+ web compiled keyboards
4 participants