-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(developer): use KeymanWeb.Codes for 17.0+ #9913
Conversation
Fixes #8147. Keyboards debug-compiled for web 17.0+ will use `KeymanWeb.Codes.` instead of `keyman.osk.`.
User Test ResultsTest specification and instructions
Test Artifacts
|
… fix/developer/8147-use-KeymanWeb.Codes
@bharanidharanj thanks for this test. It looks like you bumped up against the fix in #9901. I have rebased this to include that fix, so if you could retest this, that'd be great, thanks! @keymanapp-test-bot retest |
@mcdurdin Sure, I will do it. |
@bharanidharanj, I'm sorry, I wasn't clear on the console. The console is the Web Developer Console, available by pressing F12 and selecting the Console tab: Would you mind retesting please? @keymanapp-test-bot retest |
@mcdurdin Thanks for the clarification. Yes, I will retest and add my comment. |
Fortunately, that warning can be safely ignored 😀 so this is a pass! Thank
you!
TEST_DEBUGGER (PASSED)
|
Changes in this pull request will be available for download in Keyman version 17.0.205-alpha |
Fixes #8147.
Keyboards debug-compiled for web 17.0+ will use
KeymanWeb.Codes.
instead ofkeyman.osk.
.User Testing
store(&VERSION)
line to '17.0'. Compile the keyboard, and test it in the web debugger. Verify that the keyboard loads in Keyman Developer Server in the browser and that there are no Javascript errors (you will need to look at the Javascript console to be certain)