Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(developer): layout builder - maintain presentation during undo #9914

Conversation

mcdurdin
Copy link
Member

Fixes #7852.

When undo is run in the layout builder, it is better to keep the user's selected presentation if possible. (The selected presentation is not stored in the undo stack, but is a view property affected by the currently selected platform.)

User Testing

  • TEST_UNDO: In the Touch Layout tab of the keyboard editor, in View Controls, select 'iPad (Portait)' or 'iPhone (Portait)'. Make a change to the layout, and then press Ctrl+Z to undo (or use the Undo toolbar button). The view should remain as a portait view, and not switch back to landscape.

Fixes #7852.

When undo is run in the layout builder, it is better to keep the user's
selected presentation if possible. (The selected presentation is not
stored in the undo stack, but is a view property affected by the
currently selected platform.)
@mcdurdin mcdurdin requested a review from darcywong00 as a code owner October 31, 2023 22:02
@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels Oct 31, 2023
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Oct 31, 2023

User Test Results

Test specification and instructions

  • TEST_UNDO (PASSED): Tested with Keyman Developer 17.0.204-alpha-test-9914 on Windows 11 OS (VM) and here is my observation: 1. Opened Khmer_Angkor project. 2. Set 'iPad (portrait) in View Controls tab. 3. Added a text in a key in the Phone layout. 4. Pressed the Ctrl+Z button to Undo the changes. 5. Observed that the portrait view remains in the layout view. Seems to be working as expected. (notes)

Test Artifacts

@github-actions github-actions bot added developer/ developer/ide/ fix and removed user-test-required User tests have not been completed labels Oct 31, 2023
@keymanapp-test-bot keymanapp-test-bot bot added this to the A17S25 milestone Oct 31, 2023
Copy link
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@keymanapp-test-bot keymanapp-test-bot bot added the user-test-required User tests have not been completed label Oct 31, 2023
@bharanidharanj
Copy link

Test Results

  • TEST_UNDO (PASSED): Tested with Keyman Developer 17.0.204-alpha-test-9914 on Windows 11 OS (VM) and here is my observation: 1. Opened Khmer_Angkor project. 2. Set 'iPad (portrait) in View Controls tab. 3. Added a text in a key in the Phone layout. 4. Pressed the Ctrl+Z button to Undo the changes. 5. Observed that the portrait view remains in the layout view. Seems to be working as expected.

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Nov 1, 2023
@mcdurdin mcdurdin merged commit 0dac92d into master Nov 2, 2023
3 checks passed
@mcdurdin mcdurdin deleted the fix/developer/7852-layout-builder-maintain-presentation-during-undo branch November 2, 2023 03:54
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.204-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(developer): Ctrl-Z Resets Presentation Orientation
4 participants