Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(common): ldml update to WIP cldr data 🙀 #9919

Merged
merged 1 commit into from
Nov 3, 2023
Merged

feat(common): ldml update to WIP cldr data 🙀 #9919

merged 1 commit into from
Nov 3, 2023

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Oct 31, 2023

  • bn-bengali with a basic test
  • fr-optimise
  • note: disabling bengali reorders for now, not working properly due to tertiary reordering feat(core): tertiary reorders 🙀 feat(core): tertiary reorders 🙀  #9707

For: #9916

@keymanapp-test-bot skip

@srl295 srl295 self-assigned this Oct 31, 2023
@github-actions github-actions bot added common/ common/resources/ Build infrastructure core/ Keyman Core labels Oct 31, 2023
@srl295 srl295 added this to the A17S25 milestone Oct 31, 2023
@github-actions github-actions bot added the feat label Oct 31, 2023
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Oct 31, 2023 •
edited
Loading

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

@srl295
feat(common): ldml update to WIP cldr data 🙀
09411eb 
- bn-bengali with a basic test
- fr-optimise
- note: disabling bengali reorders for now, not working properly due to tertiary reordering feat(core): tertiary reorders 🙀  #9707

For: #9916
@srl295 srl295 force-pushed the chore/developer/9838-cldr44-moredata-epic-ldml branch from 5fdd50e to 09411eb Compare November 2, 2023 22:44
@srl295 srl295 marked this pull request as ready for review November 2, 2023 22:44
@srl295
Copy link
Member Author

srl295 commented Nov 2, 2023

this includes the keyboards but not the failing test case (for next PR)

mcdurdin
mcdurdin approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@srl295 srl295 merged commit 791a9ae into master Nov 3, 2023
2 checks passed
@srl295 srl295 deleted the chore/developer/9838-cldr44-moredata-epic-ldml branch November 3, 2023 17:29
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.205-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdurdin mcdurdin mcdurdin approved these changes

@jahorton jahorton Awaiting requested review from jahorton jahorton is a code owner

@rc-swag rc-swag Awaiting requested review from rc-swag rc-swag is a code owner

Assignees

@srl295 srl295

Labels
common/resources/ Build infrastructure common/ core/ Keyman Core feat
Projects
None yet
Milestone
A17S25
Development

Successfully merging this pull request may close these issues.
3 participants
@srl295 @keyman-server @mcdurdin