chore(developer): remove compile.pas and CompileErrorCodes.pas #9924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #9923. These are no longer used because we now use kmc for builds. This also means that the kmcomp-x64-structures test is no longer required, because that was used to keep the Delphi and C++ structures in sync. There are some minor details around error message identifiers that are still present in a handful of places, but they are work for another time.
mcdurdin
requested review from
rc-swag,
ermshiperete and
darcywong00
as code owners
User Test ResultsTest specification and instructions User tests are not required Test Artifacts |
mcdurdin
commented
Nov 2, 2023
Comment on lines
+14
to
+17
| const | ||
| // TODO: these are still used for messages raised from the IDE, perhaps need to be factored out | ||
| CERR_ERROR = $00004000; | ||
| CERR_WARNING = $00002000; |
There was a problem hiding this comment.
These came out of compile.pas
mcdurdin
commented
Nov 2, 2023
Comment on lines
-1168
to
-1174
| function ProjectCompilerMessage(line: Integer; msgcode: LongWord; text: PAnsiChar): Integer; stdcall; // I3310 // I4694 | ||
| begin | ||
| Result := ProjectCompilerMessageW(line, msgcode, String_AtoU(text)); | ||
| end; | ||
|
|
||
| function ProjectCompilerMessageW(line: Integer; msgcode: LongWord; const text: string): Integer; // I3310 // I4694 | ||
| const // from compile.pas |
There was a problem hiding this comment.
These functions no longer used because they were part of the old compiler.pas interface.
|
Changes in this pull request will be available for download in Keyman version 17.0.206-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9923.
These are no longer used because we now use kmc for builds. This also means that the kmcomp-x64-structures test is no longer required, because that was used to keep the Delphi and C++ structures in sync.
There are some minor details around error message identifiers that are still present in a handful of places, but they are work for another time.
@keymanapp-test-bot skip