fix(developer): kmc code generation for context(n) in context #9932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #9930. * Fixes the index offset calculation, with +1 for >=v10.0 keyboards and -1 for <v10.0 keyboards (difference is because older version keyboards have context offsets calculated in the opposite direction). Note that this happened because the `CODE_CONTEXTEX` index is stored in memory as 0-based in kmc, but was 1-based in kmcomp. * Adds unit tests for v9.0 and v10.0 keyboards for `context(n)` in context. * Adds unit tests for v9.0 and v10.0 keyboards for `context(n)` in output. These were already correct but now we can be assured that they are being tested. * Enables code coverage for kmw-compiler, and sets a lower threshold for pass because coverage is still just over 70%.
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
mcdurdin
deleted the
fix/developer/9930-kmc-invalid-for-context-n-in-context
branch
|
Changes in this pull request will be available for download in Keyman version 17.0.205-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9930.
Fixes the index offset calculation, with +1 for >=v10.0 keyboards and -1 for <v10.0 keyboards (difference is because older version keyboards have context offsets calculated in the opposite direction). Note that this happened because the
CODE_CONTEXTEXindex is stored in memory as 0-based in kmc, but was 1-based in kmcomp.Adds unit tests for v9.0 and v10.0 keyboards for
context(n)in context.Adds unit tests for v9.0 and v10.0 keyboards for
context(n)in output. These were already correct but now we can be assured that they are being tested.Enables code coverage for kmw-compiler, and sets a lower threshold for pass because coverage is still just over 70%.
@keymanapp-test-bot skip