Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(developer): common/include dep for kmcmplib #9935

Merged

Conversation

mcdurdin
Copy link
Member

@mcdurdin mcdurdin commented Nov 3, 2023

@mcdurdin mcdurdin requested a review from darcywong00 as a code owner November 3, 2023 06:32
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Nov 3, 2023

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

Copy link
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcdurdin mcdurdin merged commit 7878864 into master Nov 3, 2023
3 checks passed
@mcdurdin mcdurdin deleted the chore/developer/9929-common-include-dep-for-kmcmplib branch November 3, 2023 07:50
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.205-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(developer): developer/build.sh fails with keymanversion_build.h missing on a clean repo
3 participants