feat: alerts continue and complete #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think on your fork we remove the .github/workflows/add-to-keyman-project.yml That's only supposed to run on the main keyman.com repo |
|
Let's get @Meng-Heng setup to commit to the keymanapp repo rather than the fork. @darcywong00 can you help him with that? It just simplifies a bunch of things. |
mcdurdin
reviewed
Dec 4, 2024
_common/GFMAlerts.php
Outdated
Comment on lines
44
to
46
| if(empty($icon[$alertType])) { | ||
| return parent::blockQuote($block); | ||
| return null; | ||
| } |
There was a problem hiding this comment.
Shouldn't this be returning parent::blockQuote($line)?
_common/GFMAlerts.php
Outdated
Comment on lines
77
to
82
| if(isset($block['interrupted'])) { | ||
| $block['element']['text'][] = [ | ||
| 'text' => '' | ||
| ]; | ||
| unset($block['interrupted']); | ||
| } |
There was a problem hiding this comment.
I'm not sure what this is doing?
There was a problem hiding this comment.
I will change it to this
if(isset($block['interrupted'])) {
return $block;
}
To handle the interruption:
> [!TIPS]
> [!IMPORTANT]
> Do NOT do this.
> This is the last GFMAlerts
Output:
fix: improve code
mcdurdin
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I tried updating this branch with no success. It was meant for one file only. Thank you!
This PR is ready for review.
Fixes: #45