-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📝 Update commits guide #75
base: master
Are you sure you want to change the base?
Conversation
Needs #76 so that emojis don't break the linter. |
7e4edcf
to
f111311
Compare
f111311
to
9dfb865
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
counting the markdown tag emoji as only one charecter) line summarizing the | ||
nature of the commit. | ||
It should start with an appropriate emoji followed by a space | ||
then a short summary of the change made in the commit. | ||
When adding an emoji to the commit message, use the colon-ated version as | ||
opposed to the actual unicode symbol, eg: `:sparkles:`. For inspiration of what |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The set of systems that understand unicode is much larger than the set of systems that dynamically convert shortcodes to their glyphs. Using shortcodes guarantees that git log won't show them properly, whereas all a person needs to do to ensure glyph display is join the past two decades with a unicode-capable font.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using shortcodes guarantees that git log won't show them properly
What do you mean won't show them properly? Bc of line length or bc it won't render the glyphs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't convert shortcodes into glyphs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea git log doesn't but our terminals render them correctly. i thought thats what we saw the other day
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
terminals render unicode emojis. terminals do not convert ascii shortcodes into unicode emojis.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copy and paste ":smile:
" into your terminal and see what it prints. now paste 😄. Only the latter will actually show a picture of a face.
Updates commit guide with some results following discussion on git standards.