Change Channel to Source #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kieraneglin
added a commit
that referenced
this pull request
Mar 29, 2024
* Ensure channel detail lookup doesn't download the video - oops * Ran the needful migrations for replacing channels with sources * got media source test back working * channel tasks test * Media indexing worker test * media tests * Got all tests working except controller tests * got all tests working * Renamed Channel struct to Source * renamed ChannelTasks * More renaming; renamed channel details module * Removed Channel yt-dlp module, instead throwing things in the VideoCollection module * Renamed what looks like the last of the outstanding data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new?
collection_typeto newSourcemodel. This will specify whether the source covers a playlist or a channel.What's changed?
Channelmodel with near-identicalSourcemodelChannelinitially because I thought that playlists were sufficiently different to justify living in their own model. As I got further in and realized all customization happened around theChannelmodel (ie: options exist at either theMediaItemorMediaProfilelevel - not theChannellevel), I realized that this really only stores one useful bit of info (the channel's ID) and the rest was non-essential metadata. Knowing that, I thought it'd save me some headache to combine the two into a singularSourcemodel which I will expand on in future PRschannel_idfield name tocollection_id. NOT naming itsource_idbecause that's way too confusing sincesource_idimplies it tracks something internal to the app (like asource), but really it tracks the YouTube ID*Channel*modules,*channel*methods, and*channel*directory/filepaths to useSource/sourceinstead. Did the same with variable names and commentslib/pinchflat/media_client/backends/yt_dlp/channel.exin favour of just usinglib/pinchflat/media_client/backends/yt_dlp/video_collection.exWhat's fixed?
N/A
Any other comments?
Apart from the renaming, this PR doesn't really do anything (save for adding the
collection_typeattribute which I saw as necessary groundwork BUT it performs no function). This is because I wanted to separate out any meaningful logic changes into a PR with less noise and keep this scoped to the bare-minimum related to the rename.Instead of naming the
channelstable and dealing with all the indexes/FKs/whatever, I decided to just nuke it and start fresh. Such is the luxury of working with a pre-release app!