Start integrating playlist support #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kieraneglin
added a commit
that referenced
this pull request
Mar 29, 2024
* [WIP] updated the output of VideoCollection to include playlists * Updated source's name to collection_name; supported playlist ID/name fetching * Hooked up collection_type to form; refactored enqueue_pending_media_downloads * Added friendly_name to form * Added media profile link to source view * Updates comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new?
collection_typefield to track if a collection is a channel or a playlistfriendly_namefield tosourcessince playlists with duplicate names are a PITA.iex.exsfileWhat's changed?
VideoCollectionstruct as it wasn't actually benefiting me. There's only one module that needed to fulfill that contract and I can just like, you know, test that the data is in the shape I expect. It wasn't a bad thing, but it was needless so it gets culledVideoCollection'sget_source_detailsto pull in playlist IDs and TitlesMediaSourceto pull in the correctcollection_idandcollection_nameattributes based on thecollection_typeenqueue_pending_media_downloadsfrom indexing worker toSourceTasksmodule for ease-of-useWhat's fixed?
N/A
Any other comments?
N/A