Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI #4

Merged
merged 7 commits into from
Jan 20, 2024
Merged

Add CI #4

merged 7 commits into from
Jan 20, 2024

Conversation

kieraneglin
Copy link
Owner

@kieraneglin kieraneglin commented Jan 20, 2024 •
edited
Loading

What's new?

What's changed?

  • Remove ESLint, relying fully on Prettier
  • Add package.json to root just for project-wide tooling
    • Note: maybe could install Prettier globally in the development docker-run file to avoid having two package.jsons but for now I don't care

What's fixed?

N/A

Any other comments?

N/A

@kieraneglin kieraneglin merged commit fee3915 into master Jan 20, 2024
1 check passed
@kieraneglin kieraneglin deleted the ke/add-ci branch January 20, 2024 07:43
kieraneglin added a commit that referenced this pull request Mar 29, 2024
@kieraneglin
Add CI (#4)
44bec0a 
* Added credo

* Added and ran Prettier; First pass at GH Actions

* Updated actions workflow to hopefully work on this branch

* Name the folder correctly how about

* Added proper container prefix to commands

* Apparently you have to get back into the root after commands

* CI is working, update branches to final value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No CI on pull requests
1 participant
@kieraneglin