Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source attributes in output template #45

Merged
merged 5 commits into from
Mar 2, 2024
Merged

Source attributes in output template #45

merged 5 commits into from
Mar 2, 2024

Conversation

kieraneglin
Copy link
Owner

@kieraneglin kieraneglin commented Mar 2, 2024 •
edited
Loading

What's new?

  • Adds ability to use {{ source_custom_name }} and {{ source_collection_type }} in output templates
    • This is SUPER useful for when you're downloading playlists or content from multiple sources that use the same channel. Before you could only namespace by the channel or playlist name which would kinda scatter your files, but now you can keep them consolidated per-source!

What's changed?

  • Renamed the source friendly_name attribute to custom_name
  • Updated output template explainer UI to support the new attributes

What's fixed?

  • Fixes bug where media indexing wouldn't run on new records. Indexing should ALWAYS run on new source records, despite the specified index_frequency. I had updated this in UX improvements v1 #39 but I didn't test the actual job runner itself

Any other comments?

N/A

@kieraneglin kieraneglin self-assigned this Mar 2, 2024
@kieraneglin kieraneglin merged commit 8cc3692 into master Mar 2, 2024
1 check passed
@kieraneglin kieraneglin deleted the ke/source-attributes-in-output-template branch March 2, 2024 20:15
kieraneglin added a commit that referenced this pull request Mar 29, 2024
@kieraneglin
Source attributes in output template (#45)
09448e3 
* Updated download options to take a media item; allowed for specifying custom output path template options

* Fixed bug where indexing job wouldn't run for the first time

* Renamed friendly_name to custom_name

* Added new options to default template and UI

* Improved explainer UI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kieraneglin kieraneglin

Labels
bug Something isn't working enhancement New feature or request media categorization media indexing refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kieraneglin