Separate tabs for pending and downloaded in media history #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kieraneglin
requested changes
Dec 13, 2024
Comment on lines
101
to
104
| defp generate_base_query("pending") do | ||
| MediaQuery.new() | ||
| |> MediaQuery.require_assoc(:media_profile) | ||
| |> where(^dynamic(^MediaQuery.downloaded() or ^MediaQuery.pending())) |
There was a problem hiding this comment.
Since this is just for pending media items, could you please remove the MediaQuery.downloaded() from this query?
There was a problem hiding this comment.
ah shoot, forgot to change it. First i was thinking about a "All" tab. Then i realized there are also the "other" entries.
Comment on lines
61
to
65
| media_state = session["media_state"] | ||
| base_query = generate_base_query(media_state) | ||
| pagination_attrs = fetch_pagination_attributes(base_query, page) | ||
|
|
||
| {:ok, assign(socket, Map.merge(pagination_attrs, %{base_query: base_query}))} | ||
| {:ok, assign(socket, Map.merge(pagination_attrs, %{base_query: base_query, media_state: media_state}))} |
There was a problem hiding this comment.
nit: you don't need to pass media_state in the new assigns since we're not currently doing anything with that outside of the mount function.
Since that's the case, I figure you can also save the intermediate variable and just use:
base_query = generate_base_query(session["media_state"])
# ...
{:ok, assign(socket, Map.merge(pagination_attrs, %{base_query: base_query}))}
|
Looks great! Thank you |
kieraneglin
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new?
N/A
What's changed?
Media history separated tabs for downloaded and pending media items.
What's fixed?
N/A
Any other comments?
N/A