Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add sorting, pagination, and new attributes to sources index table #510

Merged
merged 12 commits into from
Dec 13, 2024

Conversation

kieraneglin
Copy link
Owner

@kieraneglin kieraneglin commented Dec 13, 2024

What's new?

The actual goal here is to have a table component that scopes its duties entirely to table-related tasks. Things like display, sorting, pagination, and eventually filtering. Right now the table LiveViews in-app handle a lot of different functionality that's relevant to their specific table, but there's no consistency. This works to fix that by creating a blueprint for creation of tables that should be easy to understand and modify, regardless of data source

TODO:

  • Ensure existing tables aren't impacted
  • Ensure the sorting UI works on smaller screens
  • Add the new truncation CSS to the table

What's changed?

  • Puts source toggle button into its own LiveComponent
  • Removes the formless-input hook
  • Refactors source index query to hopefully be faster when computing the properties of a source with many media items

What's fixed?

N/A

Any other comments?

N/A

@kieraneglin kieraneglin self-assigned this Dec 13, 2024
@kieraneglin kieraneglin changed the title [WIP] Refactor sources table [Enhancement] Add sorting, pagination, and new attributes to sources index table Dec 13, 2024
@kieraneglin kieraneglin merged commit 53e106d into master Dec 13, 2024
1 check passed
@kieraneglin kieraneglin deleted the ke/refactor-sources-table branch December 13, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Display storage consumption per source [FR] User sortable columns in sources list
1 participant