Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Added OPML Endpoint for podcast rss feeds #512

Merged
merged 9 commits into from
Dec 20, 2024
Merged

[Enhancement] Added OPML Endpoint for podcast rss feeds #512

merged 9 commits into from
Dec 20, 2024

Conversation

robertkleinschuster
Copy link
Contributor

What's new?

Added an endpoint that provides an OPML-XML of all sources. Resolves #449

What's changed?

N/A

What's fixed?

N/A

Any other comments?

N/A

  • I am the original author of this code and I am giving it freely to the community and Pinchflat project maintainers

@dozerman-ms
Copy link

Thank you!

@robertkleinschuster
Copy link
Contributor Author

robertkleinschuster commented Dec 13, 2024 •
edited
Loading

Thank you!

np, I hope I did it the right way ;)

PS: Just doing this to convince someone to get off a custom solution I built some time ago that I don't want to maintain anymore.

@dozerman-ms
Copy link

That sounds oddly similar to a Go program I wrote to generate me an OPML of my pinchflat sources. Glad to know I don't need it anymore.

@kieraneglin
Copy link
Owner

Another one! You're killing it

I'm completely busy again this weekend starting in a few hours, so I probably won't give this a full test/review until Monday or Tuesday. I did skim the code and it's looking pretty good!

@robertkleinschuster
Copy link
Contributor Author

@kieraneglin have you had any time to look at this yet?

@kieraneglin
Copy link
Owner

Not yet but I'll be taking a look shortly! I meant to yesterday but the day got away on me

kieraneglin
kieraneglin requested changes Dec 18, 2024
View reviewed changes
Copy link
Owner

@kieraneglin kieraneglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks great! I've requested some small changes - let me know if there's anything I can help clarify 🤙

Screenshot 2024-12-18 at 10 11 24 AM

lib/pinchflat/podcasts/opml_feed_builder.ex Outdated Show resolved Hide resolved
lib/pinchflat/podcasts/podcast_helpers.ex Show resolved Hide resolved
lib/pinchflat_web/controllers/podcasts/podcast_controller.ex Outdated Show resolved Hide resolved
lib/pinchflat_web/controllers/sources/source_html/index.html.heex Show resolved Hide resolved
@robertkleinschuster
Copy link
Contributor Author

Overall, looks great! I've requested some small changes - let me know if there's anything I can help clarify 🤙

Screenshot 2024-12-18 at 10 11 24 AM

Thanks for checking. I will finish the changes tomorrow.

@robertkleinschuster
Copy link
Contributor Author

@kieraneglin what is your opinion on what the route should be?

I am a bit unsure.

Maybe /sources/feed would be more consistent with the other routes.

/sources/:uuid/feed <- the feed for a specific source
/sources/feed <- the feed of sources

@kieraneglin
Copy link
Owner

@robertkleinschuster I actually like /sources/opml! It's descriptive and well scoped to the actual function the endpoint serves

@kieraneglin
Copy link
Owner

@robertkleinschuster things look good from here! Is there anything else you'd like to get in before I merge?

@robertkleinschuster
Copy link
Contributor Author

@robertkleinschuster things look good from here! Is there anything else you'd like to get in before I merge?

Thanks, let’s merge 🚀

@kieraneglin kieraneglin merged commit c9bd1ea into kieraneglin:master Dec 20, 2024
1 check passed
@kieraneglin
Copy link
Owner

Great! I'll push a new release out early next week

Thanks again for your contributions!

@kieraneglin kieraneglin added the enhancement New feature or request label Dec 20, 2024
@kieraneglin kieraneglin changed the title Added OPML Endpoint for podcast rss feeds [Enhancement] Added OPML Endpoint for podcast rss feeds Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kieraneglin kieraneglin kieraneglin approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR] Export OPML for podcast app import
3 participants
@robertkleinschuster @dozerman-ms @kieraneglin