Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use css truncate everywhere and remove StringUtils.truncate function #513

Merged
merged 1 commit into from
Dec 13, 2024
Merged

use css truncate everywhere and remove StringUtils.truncate function #513

merged 1 commit into from
Dec 13, 2024

Conversation

robertkleinschuster
Copy link
Contributor

@robertkleinschuster robertkleinschuster commented Dec 13, 2024 •
edited
Loading

What's new?

Added truncated for source names and media profile names

What's changed?

  • Replace all usages of StringUtils.truncate with css truncate
  • Prevent text wrapping in buttons

Resolves: #458

What's fixed?

N/A

Any other comments?

N/A

  • I am the original author of this code and I am giving it freely to the community and Pinchflat project maintainers

kieraneglin
kieraneglin approved these changes Dec 13, 2024
View reviewed changes
Copy link
Owner

@kieraneglin kieraneglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this - thanks for taking this on!

@kieraneglin kieraneglin merged commit e9d365e into kieraneglin:master Dec 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kieraneglin kieraneglin kieraneglin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR] Increase information density on desktop
2 participants
@robertkleinschuster @kieraneglin