Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Re-check if media is pending immediately before download #571

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

kieraneglin
Copy link
Owner

What's new?

N/A

What's changed?

  • Before, the download job didn't check for whether a media item was pending download before running the download itself. We checked its pending status before enqueuing the job but the side effect is that the job runner would still download the media item even if the source's settings changed sometime between enqueing the job and the job actually running. Now, the download job pre-checks that the media item is actually pending before downloading (unless forced)

What's fixed?

N/A

Any other comments?

N/A

@kieraneglin kieraneglin added the enhancement New feature or request label Jan 15, 2025
@kieraneglin kieraneglin self-assigned this Jan 15, 2025
@kieraneglin kieraneglin merged commit 63bb4d2 into master Jan 15, 2025
1 check passed
@kieraneglin kieraneglin deleted the ke/pending-precheck-before-download branch January 15, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Triage] Not Filtering on Download Cutoff date
1 participant