-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set up scheduler to create tasks for idle workers #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good.
About the create-worker thing, I think it makes little sense to handle this key stuff here (in the backend).
What I think makes sense to me is a create-worker
script in backend that takes a private key as string or fpath and reads it to build pubkey/fingerprint.
Setting up a worker involves various steps that will need to be documented and including an openssl command to generate one privkey (if not supplied) is not a concern.
In your workflow, the worker is created on backend and the file has to be transferred to the worker machine…
In that sense, I think we can get rid of the key generation code in cryptography and use a static fixture for the tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! thank you.
See the couple of minor suggestions to apply before merging.
Rationale
Set up scheduler to create test entries for idle workers (workers who have not been seen within the configured interval). This solves #7
Changes
last_seen_on
whenever the worker submits an update to a testnum_tests
marker to support fixed status and/or country for testsProposal
What do you think about adding a root command which takes the other commands as subcommands? Like
git
takes several subcommands. For example, if the root command was namedmirrors-qa-backend
, we could haveupdate-mirrors
,create-worker
,scheduler
as subcommands which take their own specific arguments. It would probably be done in a later ticket as the commands and entrypoints grow and some of them might share arguments like--verbose