Skip to content
This repository has been archived by the owner on Jan 9, 2025. It is now read-only.

[KGA-39] fix: default_dict_copy finalize with default value 0 #1592

Merged
merged 2 commits into from
Nov 9, 2024
Merged

[KGA-39] fix: default_dict_copy finalize with default value 0 #1592

merged 2 commits into from
Nov 9, 2024

Conversation

obatirou
Copy link
Collaborator

@obatirou obatirou commented Nov 8, 2024 •
edited
Loading

code-423n4/2024-09-kakarot-findings#91

What is the new behavior?

Use default_dict_finalize with 0

This change is Reviewable

@notion-workspace Notion Workspace
Copy link

Missing Constraint in default_dict_copy

enitrat
enitrat reviewed Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@enitrat enitrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, lgtm

one nit: should the default 0 be a constant used in all default_dict_new instances throughout the codebase?

enitrat
enitrat previously approved these changes Nov 8, 2024
View reviewed changes
@enitrat
Copy link
Collaborator

enitrat commented Nov 8, 2024

ef_tests are failing because static_Call1024PreCalls2_d0g0v0_Cancun is running out of steps. you can skip it (stStaticCall) family

@ClementWalter ClementWalter merged commit 474951c into kkrt-labs:main Nov 9, 2024
13 checks passed
@obatirou obatirou mentioned this pull request Nov 28, 2024
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ClementWalter ClementWalter ClementWalter approved these changes

@enitrat enitrat enitrat left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@obatirou @enitrat @ClementWalter