Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: get_transient_storage #413

Merged
merged 2 commits into from
Jan 15, 2025
Merged

feat: get_transient_storage #413

merged 2 commits into from
Jan 15, 2025

Conversation

obatirou
Copy link
Contributor

Close #407

enitrat
enitrat requested changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@enitrat enitrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would copy the conventions from get_storage to split very long variables a.b.c.d. in intermediate variables, only re-build the transien_storage object right before returning it, and avoid re-bindings when not necessary

@obatirou obatirou marked this pull request as draft January 14, 2025 17:06
@obatirou obatirou force-pushed the get-transient-storage branch from d5b79df to 7a617d3 Compare January 15, 2025 10:23
@obatirou obatirou force-pushed the get-transient-storage branch from 7a617d3 to be54e87 Compare January 15, 2025 10:39
@obatirou obatirou marked this pull request as ready for review January 15, 2025 10:40
@obatirou obatirou requested review from enitrat and Eikix January 15, 2025 10:40
@obatirou obatirou requested a review from enitrat January 15, 2025 12:53
@obatirou obatirou merged commit 0c48591 into main Jan 15, 2025
4 checks passed
@obatirou obatirou deleted the get-transient-storage branch January 15, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enitrat enitrat enitrat approved these changes

@Eikix Eikix Awaiting requested review from Eikix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

get_transient_storage
2 participants
@obatirou @enitrat