-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Make the codebase more modular and easier to read #32
Conversation
Now Troppical fully works like it sued to before the refactoring |
Ignore, it doesn't work
move the `filter_emulator_data` initialization to `ui_main`
Welcome page never made sense for this Now there is a proper (WIP) welcome page
And also renaming from the previous commit
Now Troppical fully works like it sued to before the refactoring Although there is still more to do
To be reworked
Also removed some unused imports throughout the UI files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have had a look at the majority of the code. I am unsure on the ui code as I have very minimal experience with PyQt6.
The code being in modular chunks is a nice addition. I tested downloading MelonDS to a custom install location and it worked fine. Nothing in the code seems explicitly wrong. I've been a bit busy so I haven't been able to be as thorough as I would have liked.
One thing I noticed is that you were varied with how you started a few files in the ui section.
imports
class
imports
class
I think it is important to keep a consistent coding style.
Other than that everything seems okay and functions as expected.
I'll fix the inconsistencies at a later date. Thank you for going through this |
Completed:
ui_main
for common functions and "__page" files for specific functions related to pages and the PyQT code itself"In progress:
Still not started: