Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Make the codebase more modular and easier to read #32

Merged
merged 33 commits into from
Nov 3, 2024

Conversation

kleidis
Copy link
Owner

@kleidis kleidis commented Oct 21, 2024

Completed:

  • A lazy importing module so communicating between modules on the codebase is easier
  • Separated UI functions into ui_main for common functions and "__page" files for specific functions related to pages and the PyQT code itself"

In progress:

  • Simplify and cleanup the refactored code

Still not started:

  • Enhance the current functions to be more fool proof

@kleidis
Copy link
Owner Author

kleidis commented Oct 23, 2024

Now Troppical fully works like it sued to before the refactoring
Although there is still more to do

@kleidis kleidis changed the base branch from dev to master October 26, 2024 11:05
@kleidis kleidis marked this pull request as ready for review November 3, 2024 16:07
Copy link
Contributor

@BlurrySquire BlurrySquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have had a look at the majority of the code. I am unsure on the ui code as I have very minimal experience with PyQt6.

The code being in modular chunks is a nice addition. I tested downloading MelonDS to a custom install location and it worked fine. Nothing in the code seems explicitly wrong. I've been a bit busy so I haven't been able to be as thorough as I would have liked.

One thing I noticed is that you were varied with how you started a few files in the ui section.

imports

class
imports
class

I think it is important to keep a consistent coding style.

Other than that everything seems okay and functions as expected.

@kleidis
Copy link
Owner Author

kleidis commented Nov 3, 2024

I'll fix the inconsistencies at a later date. Thank you for going through this

@kleidis kleidis merged commit 1910bef into master Nov 3, 2024
2 checks passed
@kleidis kleidis deleted the refactor branch November 3, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants