Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Automated] Update eventing-istio-eventing nightly #158

Conversation

knative-automation
Copy link
Contributor

/assign @knative-extensions/eventing-wg-leads
/cc @knative-extensions/eventing-wg-leads

Produced via:

for x in eventing-core.yaml eventing-crds.yaml in-memory-channel.yaml mt-channel-broker.yaml; do
  curl https://storage.googleapis.com/knative-nightly/eventing/latest/$x > ${GITHUB_WORKSPACE}/./third_party/eventing-latest/$x
done

Details:


@knative-prow knative-prow bot requested a review from a team November 17, 2023 11:05
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 17, 2023
@knative-automation knative-automation force-pushed the update-nightly/eventing branch 3 times, most recently from 700c0b3 to 9d0870d Compare November 23, 2023 11:05
Copy link
Contributor

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2023
Copy link

knative-prow bot commented Nov 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, knative-automation

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2023
@creydr
Copy link
Contributor

creydr commented Nov 23, 2023

/retest

2 similar comments
@creydr
Copy link
Contributor

creydr commented Nov 23, 2023

/retest

@creydr
Copy link
Contributor

creydr commented Nov 24, 2023

/retest

Copy link

knative-prow bot commented Nov 24, 2023

New changes are detected. LGTM label has been removed.

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2023
@knative-automation knative-automation force-pushed the update-nightly/eventing branch 2 times, most recently from e73a139 to db1d5a5 Compare November 28, 2023 11:05
@knative-automation knative-automation force-pushed the update-nightly/eventing branch 6 times, most recently from ef4185c to babd77a Compare December 6, 2023 11:05
@creydr
Copy link
Contributor

creydr commented Dec 7, 2023

log of current analysis:

Still not sure, why this only happens in eventing-istio and not in eventing-core tests too.

Update:
I think it is a combination of the changes from knative/eventing#7415 (async handler returned a 2xx when the event was accepted IIRC) and not deleting the resources correctly between control plane and data plane conformance tests (addressed in knative/eventing#7500).

@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 8, 2023
Signed-off-by: Knative Automation <[email protected]>
@knative-prow knative-prow bot merged commit 2be2aeb into knative-extensions:main Dec 8, 2023
12 checks passed
@creydr
Copy link
Contributor

creydr commented Dec 8, 2023

🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. skip-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants