Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #167

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Update dependencies #167

merged 1 commit into from
Nov 29, 2023

Conversation

creydr
Copy link
Contributor

@creydr creydr commented Nov 28, 2023

Manual update of dependencies, as update-deps job has issues at the moment with updating eventing-core submodule: https://cloud-native.slack.com/archives/C04LMU33V1S/p1700832266407189

@knative-prow knative-prow bot requested review from matzew and skonto November 28, 2023 07:52
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 28, 2023
@creydr
Copy link
Contributor Author

creydr commented Nov 28, 2023

/cc @pierDipi
I haven't found the issue in the update-deps script yet, but that way we get at least the latest eventing-core changes and can check if CI works with the changes

@knative-prow knative-prow bot requested a review from pierDipi November 28, 2023 07:54
pierDipi
pierDipi approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2023
@knative-prow Knative Prow
Copy link

knative-prow bot commented Nov 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 3c03cf9 into knative-extensions:main Nov 29, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

@matzew matzew Awaiting requested review from matzew

@skonto skonto Awaiting requested review from skonto

Assignees

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@creydr @pierDipi