Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update knative deps #4224

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dsimansk
Copy link

Fixes #

Proposed Changes

  • Update knative deps

Per title this is manual run due to gh action error with argument list too long.

/cc @pierDipi @creydr

@knative-prow knative-prow bot requested review from creydr and pierDipi January 22, 2025 16:07
@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 22, 2025
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 12.44344% with 387 lines in your changes missing coverage. Please review.

Project coverage is 48.01%. Comparing base (eea9a6a) to head (3e21e32).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
control-plane/pkg/contract/contract.pb.go 5.23% 155 Missing and 8 partials ⚠️
...ned/typed/sources/v1beta1/fake/fake_kafkasource.go 0.00% 27 Missing ⚠️
...ersioned/typed/sources/v1/fake/fake_kafkasource.go 18.51% 22 Missing ⚠️
...sioned/typed/bindings/v1/fake/fake_kafkabinding.go 0.00% 21 Missing ⚠️
...d/typed/bindings/v1beta1/fake/fake_kafkabinding.go 0.00% 21 Missing ⚠️
...ned/typed/eventing/v1alpha1/fake/fake_kafkasink.go 23.80% 16 Missing ⚠️
.../typed/messaging/v1beta1/fake/fake_kafkachannel.go 23.80% 16 Missing ⚠️
...skafkaeventing/v1alpha1/fake/fake_consumergroup.go 44.44% 15 Missing ⚠️
...ernalskafkaeventing/v1alpha1/fake/fake_consumer.go 42.85% 12 Missing ⚠️
...d/internalskafkaeventing/v1alpha1/consumergroup.go 0.00% 11 Missing ⚠️
... and 10 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4224      +/-   ##
==========================================
+ Coverage   45.44%   48.01%   +2.56%     
==========================================
  Files         270      270              
  Lines       19893    18737    -1156     
==========================================
- Hits         9041     8996      -45     
+ Misses      10133     9029    -1104     
+ Partials      719      712       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierDipi
Copy link
Member

Thank you @dsimansk

@pierDipi
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2025
Copy link

knative-prow bot commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi
Copy link
Member

It's failing on https://github.com/knative-extensions/eventing-kafka-broker/actions/runs/12912279279/job/36006722888?pr=4224


knative-extensions/eventing-kafka-broker is out of date. Please run hack/update-codegen.sh

@pierDipi
Copy link
Member

/lgtm cancel

@knative-prow knative-prow bot added area/control-plane area/data-plane and removed lgtm Indicates that a PR is ready to be merged. labels Jan 22, 2025
@dsimansk dsimansk force-pushed the pr/update-knative-versions branch from a5dd8a1 to 70c3dc5 Compare January 23, 2025 08:45
@dsimansk dsimansk force-pushed the pr/update-knative-versions branch from 70c3dc5 to da00fb6 Compare January 23, 2025 11:05
Copy link

knative-prow bot commented Jan 23, 2025

@dsimansk: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
unit-tests_eventing-kafka-broker_main 3e21e32 link true /test unit-tests
build-tests_eventing-kafka-broker_main 3e21e32 link true /test build-tests
channel-integration-tests-ssl_eventing-kafka-broker_main 3e21e32 link true /test channel-integration-tests-ssl
reconciler-tests-keda_eventing-kafka-broker_main 3e21e32 link true /test reconciler-tests-keda
reconciler-tests-namespaced-broker_eventing-kafka-broker_main 3e21e32 link true /test reconciler-tests-namespaced-broker
channel-reconciler-tests-sasl-plain_eventing-kafka-broker_main 3e21e32 link true /test channel-reconciler-tests-sasl-plain
upgrade-tests_eventing-kafka-broker_main 3e21e32 link true /test upgrade-tests
reconciler-tests_eventing-kafka-broker_main 3e21e32 link true /test reconciler-tests
channel-integration-tests-sasl-ssl_eventing-kafka-broker_main 3e21e32 link true /test channel-integration-tests-sasl-ssl
channel-integration-tests-sasl-plain_eventing-kafka-broker_main 3e21e32 link true /test channel-integration-tests-sasl-plain
channel-reconciler-tests-sasl-ssl_eventing-kafka-broker_main 3e21e32 link true /test channel-reconciler-tests-sasl-ssl
integration-tests_eventing-kafka-broker_main 3e21e32 link true /test integration-tests
channel-reconciler-tests-ssl_eventing-kafka-broker_main 3e21e32 link true /test channel-reconciler-tests-ssl

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane area/data-plane size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants