Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kind Quickstart: Add extraMount Option #522

Merged
merged 4 commits into from
Jun 14, 2024

Conversation

eupharis
Copy link
Contributor

@eupharis eupharis commented Jun 14, 2024

Changes

Added two extra CLI arguments to quickstart kind:

extraMountHostPath and extraMountContainerPath.

extraMounts must be setup at the time nodes are created. So I had to change the quickstart plugin itself, rather than just applying the change after quickstart ran.

kn quickstart kind --registry --extraMountHostPath=/home/daniel/foo --extraMountContainerPath=/foo
  • 🎁 Add new feature

/kind enhancement

We use kn-quickstart as a nice way to boostrap local developers environments for testing Knative before changes go to our real Knative development server.

Release Note

Added support for a Kind `extraMount` during cluster creation with the `extraMountHostPath` and `extraMountContainerPath` command line arguments.

Docs

Updated quickstart readme to document

- [Other doc]: https://github.com/eupharis/kn-plugin-quickstart?tab=readme-ov-file#quickstart-with-kind

Copy link

linux-foundation-easycla bot commented Jun 14, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

knative-prow bot commented Jun 14, 2024

Welcome @eupharis! It looks like this is your first PR to knative-extensions/kn-plugin-quickstart 🎉

Copy link

knative-prow bot commented Jun 14, 2024

Hi @eupharis. Thanks for your PR.

I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 14, 2024
@psschwei
Copy link
Contributor

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 14, 2024
Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This doesn't work as written, I think you'll need to update the kind config.

pkg/kind/kind.go Outdated Show resolved Hide resolved
pkg/kind/kind.go Show resolved Hide resolved
Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2024
Copy link

knative-prow bot commented Jun 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eupharis, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2024
@knative-prow knative-prow bot merged commit ac9614f into knative-extensions:main Jun 14, 2024
22 checks passed
@eupharis
Copy link
Contributor Author

@psschwei awesome!! thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants