-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kind Quickstart: Add extraMount
Option
#522
Conversation
Welcome @eupharis! It looks like this is your first PR to knative-extensions/kn-plugin-quickstart 🎉 |
Hi @eupharis. Thanks for your PR. I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! This doesn't work as written, I think you'll need to update the kind config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eupharis, psschwei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@psschwei awesome!! thanks! |
Changes
Added two extra CLI arguments to
quickstart kind
:extraMountHostPath
andextraMountContainerPath
.extraMounts must be setup at the time nodes are created. So I had to change the quickstart plugin itself, rather than just applying the change after
quickstart
ran./kind enhancement
We use
kn-quickstart
as a nice way to boostrap local developers environments for testing Knative before changes go to our real Knative development server.Release Note
Docs
Updated quickstart readme to document