feat: Price sort by logic

[hassnian]

PR Type

• Bugfix
• Feature
• Refactoring

Needs Design check

• @exezbcz please review

Context

• Closes Price sort by logic  #8890

Did your issue had any of the "$" label on it?

• Fill up your DOT address: Payout

Screenshot 📸

• My fix has changed something on UI;

[kodabot]

SUCCESS @hassnian PR for issue #8890 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

[netlify]

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	9ae4572
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/65d6f82e7e9e3f0008669a3d
😎 Deploy Preview	https://deploy-preview-8920--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[reviewpad]

AI-Generated Summary: This pull request involves significant refactoring of the useItemsGrid.ts and en.json files. In useItemsGrid.ts, a considerable chunk of code related to the price sorting logic is removed. This includes the removal of the isPriceSortActive function and a watch method that previously observed changes in the route.query.sort value. Furthermore, in the en.json file, the value for the "listed" key is changed from "Buy now" to "Listed".

[hassnian]

@exezbcz pls check , let me know if it's working as you mentioned

[exezbcz]

nope, not working yet

when this filter is applied it should show listed first - sorted by price and then the rest

[hassnian]

sorted by price and then the rest

@roiLeo this is not possible only using tokenListWithSearch query right ?

[roiLeo]

sorted by price and then the rest

@roiLeo this is not possible only using tokenListWithSearch query right ?

Doesn't look like it's possible with tokenEntities this might be indexer issue, let's open issue on https://github.com/kodadot/stick/issues with what you need

[yangwao]

waiting to resolve this

• orderBy price ascending should put prioritise "listed" tokens stick#188

[preschian]

blocked by this. lets re-review again once ready

waiting to resolve this

• orderBy price ascending should put prioritise "listed" tokens stick#188

[yangwao]

@vikiival can do silent release of new Stick for you

• 🎉 🏹 🦑 Hello stick#194

[vikiival]

https://squid.subsquid.io/arrow-speck/v/v1/graphql

[codeclimate]

Code Climate has analyzed commit 9ae4572 and detected 0 issues on this pull request.

View more on Code Climate.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[hassnian]

https://squid.subsquid.io/arrow-speck/v/v1/graphql

can you deploy it again

thanks

[vikiival]

can you deploy it again

Blocked by

• update or delete on table "token_entity" violates foreign key constraint stick#220

[vikiival]

meanwhile we run arrowsquid, prob continue?

[hassnian]

meanwhile we run arrowsquid, prob continue?

yes

when the low to high filter is active, show listed first, sorted by the sort by filter, and then leave the rest untouched. It takes all the supply and just reorders it so the listed ones are on top.

we have

and we need price_ASC_NULL_LAST

[vikiival]

yes

[vikiival]

I have missunderstood your question @hassnian

closing as this is not resolved

https://t.me/HydraDevs/9433

• ⚡ asc nulls last in order by subsquid/squid-sdk#270

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[hassnian]

@vikiival any updates ? is kodadot/stick#275 the blocker ?

[vikiival]

Yes

[hassnian]

new pr #10529