Jiggyjiggy #3
Open
Jiggyjiggy #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khyojun
reviewed
Nov 26, 2022
| } | ||
| } | ||
| private void validateRange(List<Integer> input) { | ||
| if (!(input.stream().allMatch(v -> 1 <= v && v <= 9))) { |
There was a problem hiding this comment.
이 부분은 stream도 좋지만 정규표현식도 시도해보시면 좋을 거 같아요.
khyojun
reviewed
Nov 26, 2022
| private void updateBallCount(int computerDigit, int inputDigit) { | ||
| if (computerDigit == inputDigit) { | ||
| updateNumberOfStrike(); | ||
| } else { |
There was a problem hiding this comment.
else문 보다는 return문 사용하시면 좋을 거 같아요.
|
number class (domain) 을 두고 형식에 대한 validate 처리를 하면 좋을 것 같다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.