test #3
Open
test #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khyojun
reviewed
Dec 4, 2022
| private String getResultMessage(List<String> moveResults) { | ||
| return format(GAME_OUTPUT_MESSAGE,moveResults.stream() | ||
| .map(i-> MoveResult.getCommand()) | ||
| .collect(Collectors.joining(GAME_DELIMITER_MESSAGE))); |
There was a problem hiding this comment.
이 과정은 다른 곳에서 처리하고 view에선 출력만 해주면 좋을거 같아요!
| public class BridgeGameController { | ||
|
|
||
| private InputView inputView = new InputView(); | ||
| private OutputView outputView = new OutputView(); |
There was a problem hiding this comment.
그 객체가 이렇게 초기화를 시킨다고 본래는 생각하고 있지만 기본 생성자를 이용하여서 초기화를 먼저 해주어야지 진짜로 초기화 해주시는 거라고 하시더라구요.
그래서 앞으로 생성자 안에서 객체 초기화 시켜주시면 좋을 거 같아요
ex)
BridgeGameController{
this.inputView=new InputView();
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.