🌱 Setup CI workflow to use same container as Dockerfile #1804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjd78
added
the
cherry-pick/release-0.3
rszwajko
reviewed
Apr 4, 2024
Lookup the "FROM .* as builder" image from the project's Dockerfile, and use that image to run the CI unit-test job. This will ensure the unit-test job is using the same container image that the image builds will be using. A problem with the container should show up quickly in the unit-testing. Signed-off-by: Scott J Dickerson <[email protected]>
|
Kicked the codecov resolution to #1820 |
rszwajko
approved these changes
Apr 5, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Apr 5, 2024
Lookup the "FROM .* as builder" image from the project's Dockerfile, and use that image to run the CI unit-test job. This will ensure the unit-test job is using the same container image that the image builds will be using. A problem with the container should show up quickly in the unit-testing. Signed-off-by: Scott J Dickerson <[email protected]> Signed-off-by: Cherry Picker <[email protected]>
sjd78
pushed a commit
that referenced
this pull request
Apr 5, 2024
Lookup the "FROM .* as builder" image from the project's Dockerfile, and use that image to run the CI unit-test job. This will ensure the unit-test job is using the same container image that the image builds will be using. A problem with the container should show up quickly in the unit-testing. Signed-off-by: Scott J Dickerson <[email protected]> Signed-off-by: Cherry Picker <[email protected]>
sjd78
added a commit
to sjd78/tackle2-ui
that referenced
this pull request
Apr 19, 2024
Backport repo level CI updates following changes in konveyor#1804 and others. This will allow the "required" PR check of "unit-test" to be run on the release-0.2 branch. Signed-off-by: Scott J Dickerson <[email protected]>
sjd78
added a commit
to sjd78/tackle2-ui
that referenced
this pull request
Apr 19, 2024
Backport repo level CI updates following changes in konveyor#1804 and others. This will allow the "required" PR check of "unit-test" to be run on the release-0.2 branch. Specific changes: - Workflow `ci-actions.yml` replaced by `ci-repo.yml` - Add `./scripts/verify_lock.mjs` - Disable codecov uploads since we don't need it on an old release branch Signed-off-by: Scott J Dickerson <[email protected]>
sjd78
added a commit
that referenced
this pull request
Apr 19, 2024
Backport repo level CI updates following changes in #1804 and others. This will allow the "required" PR check of "unit-test" to be run on the release-0.2 branch. Specific changes: - Workflow `ci-actions.yml` replaced by `ci-repo.yml` - Add `./scripts/verify_lock.mjs` updated for the branch's package.json project structure - Disable the lint step since linting does not exist on release-0.2 - Disable codecov uploads since we don't need it on an old release branch --------- Signed-off-by: Scott J Dickerson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lookup the "FROM .* as builder" image from the project's Dockerfile, and use that image to run the CI unit-test job.
This will ensure the unit-test job is using the same container image that the image builds will be using. A problem with the container should show up quickly in the unit-testing.